extensions: add http bandwidth limit filter by nitgoy · Pull Request #14096 · envoyproxy/envoy

nitgoy · 2020-11-19T11:40:04Z

Commit Message: adds bandwidth limit filter core functionality and UTs
Additional Description: the filter smoothens the flow of data in both direction up to the specified bandwidth limit.
Risk Level:
Testing: UTs added. Adding more UTs and integration tests.
Docs Changes: Pending
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #13604]
[Optional Deprecated:]

repokitteh-read-only · 2020-11-19T11:40:06Z

Hi @nitgoy, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #14096 was opened by nitgoy.

see: more, trace.

repokitteh-read-only · 2020-11-19T11:40:10Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #14096 was opened by nitgoy.

see: more, trace.

tonya11en

Looks great!

You'll want to see how other filters implement their config as an alpha version so the proto isn't locked in.

Let's use this PR for the whole filter review! I'll stand by for the rest of it. Thanks for doing this.

api/envoy/extensions/filters/http/bandwidth_limit/v3/bandwidth_limit.proto

Signed-off-by: Nitin <nigoyal@microsoft.com>

Signed-off-by: Nitin <nigoyal@microsoft.com> Signed-off-by: Nitin Goyal <nrk.goyal@gmail.com>

…m rate limiter Signed-off-by: Nitin <nigoyal@microsoft.com>

Signed-off-by: Nitin <nigoyal@microsoft.com>

…ate limiter Signed-off-by: Nitin <nigoyal@microsoft.com>

Signed-off-by: Nitin <nigoyal@microsoft.com>

nitgoy · 2021-01-26T13:26:30Z

As suggested, I've created two separate PRs:
Token bucket: #14827
Stream rate limiter: #14828

Hope to get those merged while I address the remaining comments here.

mattklein123 · 2021-01-31T19:31:45Z

Sorry I haven't looked at this yet, but will put this in waiting until the base PRs are merged and then we can circle back.

/wait

leoribeiro2 · 2021-03-10T20:56:45Z

Hi guys!
Have you any updates about that feat?

@nitgoy

github-actions · 2021-04-10T00:03:32Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

nitgoy · 2021-04-11T20:20:17Z

Hi guys!
Have you any updates about that feat?

@nitgoy

Sorry it's taken so long. We're now using it for our product so that helped to uncover some functional issues. Hoping to push out new changes pretty soon. Most likely after completing this dependent PR: #14828

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

api/envoy/extensions/filters/http/bandwidth_limit/v3alpha/bandwidth_limit.proto

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

nitgoy · 2021-05-06T08:07:07Z

I have opened a replacement PR for this one after addressing most of the comments: #16358. I was running into some DCO issues which were getting non-trivial to fix. Please take a look at the new PR, will close this one.

nitgoy and others added 16 commits November 2, 2020 18:23

Add bandwidthlimit filter skeleton

6c0814d

Get latest from upstream

321c212

Merge branch 'master' of github.com:nitgoy/envoy into bandwidthlimit

b252696

fix build

2628f56

Add core logic

68c9e38

fix build

f4ef50d

minor fix

4a4067b

Add bandwidthlimit filter skeleton

b0d15d1

fix build

b739410

Add core logic

6558557

fix build

981a3ab

minor fix

1096758

minor

83d4fb9

merge rebase

76fb754

add generated configs

63d731b

final build fixes

93f96c1

repokitteh-read-only bot added the api label Nov 19, 2020

nitgoy mentioned this pull request Nov 19, 2020

how to config bandwidth limit #13604

Closed

mattklein123 assigned tonya11en Nov 20, 2020

tonya11en reviewed Nov 23, 2020

View reviewed changes

nitgoy force-pushed the bandwidthlimitproto branch from 1526a7e to 1f11d00 Compare December 2, 2020 05:09

nitgoy and others added 7 commits December 3, 2020 19:14

config and test related changes

3aafb4e

Signed-off-by: Nitin <nigoyal@microsoft.com>

fix spellings

42e46d9

Signed-off-by: Nitin <nigoyal@microsoft.com>

update generated config

87c2751

Signed-off-by: Nitin <nigoyal@microsoft.com>

move configs to v3alpha

5da9feb

bandwidth limit filter config

036fbed

Signed-off-by: Nitin <nigoyal@microsoft.com> Signed-off-by: Nitin Goyal <nrk.goyal@gmail.com>

Address comments: remove enforce threshold

6b95e43

Signed-off-by: Nitin <nigoyal@microsoft.com> Signed-off-by: Nitin Goyal <nrk.goyal@gmail.com>

move proto to alpha

45840d2

Signed-off-by: Nitin <nigoyal@microsoft.com> Signed-off-by: Nitin Goyal <nrk.goyal@gmail.com>

nitgoy added 5 commits January 5, 2021 18:54

make token bucket conditionally thread-safe and add comment for strea…

56c50ea

…m rate limiter Signed-off-by: Nitin <nigoyal@microsoft.com>

fix reset

662bf2b

Signed-off-by: Nitin <nigoyal@microsoft.com>

make token bucket optionally thread-safe and add comment for stream r…

8a0904b

…ate limiter Signed-off-by: Nitin <nigoyal@microsoft.com>

remove some absl guards

bd537f9

Signed-off-by: Nitin <nigoyal@microsoft.com>

Merge branch 'bwprotodev' into bandwidthlimitproto

91e5b25

Signed-off-by: Nitin <nigoyal@microsoft.com>

Base automatically changed from master to main January 15, 2021 23:01

nitgoy mentioned this pull request Jan 27, 2021

common: add a thread safe token bucket #14827

Merged

repokitteh-read-only bot added the waiting label Jan 31, 2021

github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 10, 2021

github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 12, 2021

merge from upstream

36438b6

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

repokitteh-read-only bot removed the waiting label Apr 14, 2021

mattklein123 removed their assignment Apr 16, 2021

nitgoy added 2 commits April 22, 2021 14:24

merge streamlimiter changes from upstream

abee221

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

update filter

6b4eb66

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

phlax reviewed Apr 28, 2021

View reviewed changes

api/envoy/extensions/filters/http/bandwidth_limit/v3alpha/bandwidth_limit.proto Outdated Show resolved Hide resolved

phlax reviewed Apr 28, 2021

View reviewed changes

api/envoy/extensions/filters/http/bandwidth_limit/v3alpha/bandwidth_limit.proto Outdated Show resolved Hide resolved

update proto

4c2a96d

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

nitgoy marked this pull request as ready for review May 4, 2021 21:56

nitgoy added 3 commits May 5, 2021 22:39

add docs

a48c556

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

proto and doc fixes

890ce21

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

test fix

2cbf38f

Signed-off-by: Nitin Goyal <nigoyal@microsoft.com>

nitgoy closed this May 6, 2021

nitgoy deleted the bandwidthlimitproto branch June 3, 2021 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extensions: add http bandwidth limit filter#14096

extensions: add http bandwidth limit filter#14096
nitgoy wants to merge 53 commits intoenvoyproxy:mainfrom
nitgoy:bandwidthlimitproto

nitgoy commented Nov 19, 2020 •

edited

Loading

Uh oh!

repokitteh-read-only bot commented Nov 19, 2020

Uh oh!

repokitteh-read-only bot commented Nov 19, 2020

Uh oh!

tonya11en left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nitgoy commented Jan 26, 2021 •

edited

Loading

Uh oh!

mattklein123 commented Jan 31, 2021

Uh oh!

leoribeiro2 commented Mar 10, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Apr 10, 2021

Uh oh!

nitgoy commented Apr 11, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

nitgoy commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nitgoy commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Nov 19, 2020

Uh oh!

repokitteh-read-only bot commented Nov 19, 2020

Uh oh!

tonya11en left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nitgoy commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattklein123 commented Jan 31, 2021

Uh oh!

leoribeiro2 commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2021

Uh oh!

nitgoy commented Apr 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nitgoy commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nitgoy commented Nov 19, 2020 •

edited

Loading

nitgoy commented Jan 26, 2021 •

edited

Loading

leoribeiro2 commented Mar 10, 2021 •

edited

Loading

nitgoy commented Apr 11, 2021 •

edited

Loading