backport to 1.13: Prevent SEGFAULT when disabling listener (#13515)#14036
Closed
cpakulski wants to merge 2 commits intoenvoyproxy:release/v1.13from
Closed
backport to 1.13: Prevent SEGFAULT when disabling listener (#13515)#14036cpakulski wants to merge 2 commits intoenvoyproxy:release/v1.13from
cpakulski wants to merge 2 commits intoenvoyproxy:release/v1.13from
Conversation
This prevents the stop_listening overload action from causing segmentation faults that can occur if the action is enabled after the listener has already shut down. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Contributor
Author
Contributor
|
Nope, the problem is only in calls to those methods. Sounds like there's no bug to be fixed! |
Contributor
Author
|
@akonradi Thanks for confirming that! I am closing that PR and mark your original PR as successfully backported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.
Risk Level: low
Testing: unit tests
Docs Changes: none
Release Notes: Yes
Fixes #13514