backport: Prevent SEGFAULT when disabling listener (#13515)#13882
backport: Prevent SEGFAULT when disabling listener (#13515)#13882ggreenway merged 5 commits intoenvoyproxy:release/v1.16from
Conversation
This prevents the stop_listening overload action from causing segmentation faults that can occur if the action is enabled after the listener has already shut down. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
|
Fix looks good. Don't we need to update docs/root/version_history/current.rst? |
Yes, this needs a release-note. /wait |
The original change didn't have a release note, but it sounds like we may want to add one for the backport. |
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
|
|
||
| This prevents the stop_listening overload action from causing | ||
| segmentation faults that can occur if the action is enabled after the | ||
| listener has already shut down. |
There was a problem hiding this comment.
Release notes are typically a single line. See examples at: https://raw.githubusercontent.com/envoyproxy/envoy/master/docs/root/version_history/v1.16.0.rst
For this specific one I suggest the following wording:
listener: fix crash when disabling or re-enabling listeners due to overload while processing LDS updates
There was a problem hiding this comment.
@antoniovicente Thanks for suggestion! It is corrected now.
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Many thanks for the help on the backport effort.
|
/retest |
|
Retrying Azure Pipelines: |
* backport: Prevent SEGFAULT when disabling listener (envoyproxy#13515) (envoyproxy#13882) * Prevent SEGFAULT when disabling listener (envoyproxy#13515) This prevents the stop_listening overload action from causing segmentation faults that can occur if the action is enabled after the listener has already shut down. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * backport to rel-1.16: proxy_proto - fixing hashing bug envoyproxy#13768 (envoyproxy#13966) Fix a bug where the transport socket options for the first downstream got reused for subsequent upstream connections. Risk Level: low Testing: new integration test Docs Changes: n/a Release Notes: Platform Specific Features: Fixes envoyproxy#13659 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
4 participants
Commit Message:
This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.
Risk Level: low
Testing: unit tests
Docs Changes: none
Release Notes: none
Fixes #13514