examples: Add TLS sandbox#13844
Merged
mattklein123 merged 45 commits intoenvoyproxy:masterfrom Nov 11, 2020
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Oct 31, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Oct 31, 2020
Member
Author
|
latest docs render: https://storage.googleapis.com/envoy-pr/d687992/docs/start/sandboxes/tls.html |
phlax
commented
Oct 31, 2020
phlax
commented
Oct 31, 2020
phlax
commented
Oct 31, 2020
phlax
commented
Oct 31, 2020
phlax
commented
Oct 31, 2020
phlax
commented
Oct 31, 2020
phlax
commented
Nov 10, 2020
phlax
commented
Nov 10, 2020
phlax
commented
Nov 10, 2020
Member
Author
|
@mattklein123 i created a separate pr to handle SNI here #13975 (its early wip) this one should be ready for final review hopefully - latest render is here https://storage.googleapis.com/envoy-pr/2f6d39c/docs/start/sandboxes/tls.html worth noting, ive added a "requirements" pullout its my ~intention to remove all of the "install docker" and "clone envoy repo" sections from the sandboxes and instead link a single page with these instructions - probably from this requirements box |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Nov 11, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM to ship and iterate! Very nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Add TLS sandbox
Additional Description:
this provides the following examples
http->httpshttps->httphttps->httpshttpspassthroughRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13373
[Optional Deprecated:]