dns: preserve custom resolver after channel destruction#13820
Merged
mattklein123 merged 11 commits intoenvoyproxy:masterfrom Oct 30, 2020
junr03:custom-resolvers
Merged
dns: preserve custom resolver after channel destruction#13820mattklein123 merged 11 commits intoenvoyproxy:masterfrom junr03:custom-resolvers
mattklein123 merged 11 commits intoenvoyproxy:masterfrom
junr03:custom-resolvers
Conversation
added 9 commits
October 29, 2020 09:59
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
added 2 commits
October 29, 2020 13:55
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
|
/retest |
|
Retrying Azure Pipelines: |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: dns: preserve custom resolver after channel destruction (envoyproxy#13820) docs: Further updates to quick-start (envoyproxy#13793) wasm: update V8 to v8.7.220.10. (envoyproxy#13568) test: adding a test for CONNECT to an IP address (envoyproxy#13818) [fuzz] Scaled Load balancer fuzz to 60k hosts (envoyproxy#13771) Removed Circle-CI reference. (envoyproxy#13824) wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775) examples: Add dynamic configuration (filesystem) sandbox (envoyproxy#13783) apple dns: resolve IP addresses without calling Apple APIs (envoyproxy#13698) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dns - preserve custom resolver after channel destruction
Additional Description: previously when the c-ares channel was destroyed and re-initialized, custom resolver addresses passed in during construction were not preserved. This PR reproduces the issue with a new test, and fixes.
Risk Level: low - fixing issue with reproduced test
Testing: repro issue, and verified fix with new unit test.
Release Notes: updated
Fixes #13794
Signed-off-by: Jose Nino jnino@lyft.com