Skip to content

[fuzz] Added status frame support to h2 fuzz test#13807

Merged
asraa merged 2 commits intoenvoyproxy:masterfrom
zasweq:add-status-frame-h2-fuzz
Nov 2, 2020
Merged

[fuzz] Added status frame support to h2 fuzz test#13807
asraa merged 2 commits intoenvoyproxy:masterfrom
zasweq:add-status-frame-h2-fuzz

Conversation

@zasweq
Copy link
Contributor

@zasweq zasweq commented Oct 28, 2020

Signed-off-by: Zach Reyes zasweq@google.com

Commit Message: Added status frame support to h2 fuzz test
Additional Description: I added status frame to http2frame to test overflowed statuses in #13314. I added this frame to h2_fuzz.cc.
Risk Level: Low
Testing: Added regression test

Signed-off-by: Zach <zasweq@google.com>
@zasweq
Copy link
Contributor Author

zasweq commented Oct 28, 2020

/assign @asraa @htuch @adisuissa

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
BTW: Is the plan to make a more generic multiple headers integration fuzz tests?

@yanavlasov
Copy link
Contributor

/wait

@asraa
Copy link
Contributor

asraa commented Oct 29, 2020

BTW: Is the plan to make a more generic multiple headers integration fuzz tests?

There is the unit request/response header frame fuzz test, which just feeds headers frames to the connection. I'm not sure how much overlap there will be with those, i think it's good to have both coverage here and there.

Signed-off-by: Zach <zasweq@google.com>
@zasweq
Copy link
Contributor Author

zasweq commented Oct 30, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13807 (comment) was created by @zasweq.

see: more, trace.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa asraa merged commit cec00e6 into envoyproxy:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants