tls: Typesafe tls slots#13789
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
@mattklein123 ptal -- this is not ready to go yet -- needs unit tests and covering the other existing dynamically typed uses of Tls::SlotPtr, but I wanted to see if you liked the pattern before I use it everywhere.
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
This is great! Happy to continue in this direction.
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
Thanks in general this LGTM. Do you want to do all sites? Or just land this first and then do some further PRs? /wait |
|
I think I'll try to get this in first and then iterate on the rest of the sites. But first I want to survey the existing sites to see if there's any gap in usage. In particular I am interested in cases where we are returning a new value from the runOnAllThreads lambda. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is nice! Just a few small comments.
/wait
…us misc comments. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks. @akonradi any other comments?
akonradi
left a comment
akonradi
left a comment
There was a problem hiding this comment.
LGTM, nice! Just the one nit
|
/retest |
|
Retrying Azure Pipelines: |
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
3 participants
Commit Message: Adds a new
TypedSlotAPI, where the slot data is strongly typed. Also removes an unused capability to replace slot data with a new instance via the callbacks inrunOnAllThreads.Use this new API rather than the untyped
SlotAPI for one of the sites (stats thread_local_store.cc).This is a partial fix for #13313
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a