Skip to content

cloned PR: caching: Stream cached responses in chunks and handle downstream backpressure#13714

Closed
zyshi wants to merge 1 commit intoenvoyproxy:masterfrom
zyshi:13054_tests
Closed

cloned PR: caching: Stream cached responses in chunks and handle downstream backpressure#13714
zyshi wants to merge 1 commit intoenvoyproxy:masterfrom
zyshi:13054_tests

Conversation

@zyshi
Copy link

@zyshi zyshi commented Oct 22, 2020

Patching #13054

Commit Message:
The CacheFilter now streams cached responses in chunks and handles downstream backpressure.
Signed-off-by: Yosry Ahmed yosryahmed@google.com

Additional Description:
The CacheFilter now:

  • Does not stop headers encoding until the cached response is fetched.
  • Streams the cached response downstream in chunks, according to the encoding buffer size.
  • Subscribes to downstream watermark events and handles downstream backpressure by stopping fetching the response body from the cache.

Risk Level: Low
Testing: Unit / Integration
Docs Changes: N/A
Release Notes: N/A
Fixes #9835

Patching envoyproxy#13054

Signed-off-by: Zhongyi Shi <zhongyi@chromium.org>
@zyshi zyshi requested a review from jmarantz as a code owner October 22, 2020 21:52
@jmarantz jmarantz self-assigned this Oct 23, 2020
@zyshi zyshi changed the title CacheFilter does not stop headers iteration when encoding a response cloned PR: caching: Stream cached responses in chunks and handle downstream backpressure Oct 23, 2020
@zyshi zyshi marked this pull request as draft October 24, 2020 03:06
@zyshi
Copy link
Author

zyshi commented Oct 24, 2020

Actually I got the write permission to the original PR, so I'll use the original PR to continue the contribution. Sorry about the noise.

@zyshi zyshi closed this Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CacheFilter: Handle backpressure from downstream

2 participants