Skip to content

wasm: re-enable tests with precompiled modules. #13583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Oct 17, 2020
Merged

wasm: re-enable tests with precompiled modules. #13583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed77851
wasm: re-enable tests with precompiled modules.
PiotrSikora Oct 15, 2020
f8ae707
Merge remote-tracking branch 'origin/master' into PiotrSikora/fix_was…
PiotrSikora Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions test/extensions/common/wasm/wasm_vm_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,6 @@ TEST_P(WasmVmTest, V8BadCode) {
}

TEST_P(WasmVmTest, V8Code) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);
EXPECT_TRUE(wasm_vm->runtime() == "v8");
Expand All @@ -171,13 +164,6 @@ TEST_P(WasmVmTest, V8Code) {
}

TEST_P(WasmVmTest, V8BadHostFunctions) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand All @@ -199,13 +185,6 @@ TEST_P(WasmVmTest, V8BadHostFunctions) {
}

TEST_P(WasmVmTest, V8BadModuleFunctions) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down Expand Up @@ -234,13 +213,6 @@ TEST_P(WasmVmTest, V8BadModuleFunctions) {
}

TEST_P(WasmVmTest, V8FunctionCalls) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down Expand Up @@ -279,13 +251,6 @@ TEST_P(WasmVmTest, V8FunctionCalls) {
}

TEST_P(WasmVmTest, V8Memory) {
#ifndef NDEBUG
// Do not execute pre-compilation tests in debug mode because V8 will fail to load because the
// flags do not match. TODO: restore this test when the rust toolchain is integrated.
if (GetParam() == 1) {
return;
}
#endif
auto wasm_vm = createWasmVm("envoy.wasm.runtime.v8", scope_);
ASSERT_TRUE(wasm_vm != nullptr);

Expand Down