Skip to content

[fuzz] Fixed divide by zero bug #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 4 commits into from
Oct 19, 2020
Merged

[fuzz] Fixed divide by zero bug #13545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc0162f
Fixed divide by zero bug
zasweq Oct 13, 2020
df8cf78
Changed return to correct value
zasweq Oct 13, 2020
51a40b6
Switched to exception
zasweq Oct 14, 2020
40cc89d
Added unit test for exception throw
zasweq Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/extensions/filters/http/admission_control/admission_control.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ double AdmissionControlFilterConfig::aggression() const {

double AdmissionControlFilterConfig::successRateThreshold() const {
const double pct = sr_threshold_ ? sr_threshold_->value() : defaultSuccessRateThreshold;
// The threshold value should not be 0. Since you cannot add a validation on a widely used Runtime
// percent value, simply map a 0 percent for the field to the default success rate threshold.
if (pct == 0) {

@htuch htuch Oct 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead throw during config ingest? (not here)

return defaultSuccessRateThreshold;
Comment thread
zasweq marked this conversation as resolved.
Outdated
}
return std::min<double>(pct, 100.0) / 100.0;
}

Expand Down
12 changes: 12 additions & 0 deletions ...ers/http/common/fuzz/filter_corpus/clusterfuzz-testcase-filter_fuzz_test-5914972389113856
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.