lua: Expose stream info downstreamLocalAddress and downstreamDirectRemoteAddress for Lua filter#13536
Merged
mattklein123 merged 14 commits intoenvoyproxy:masterfrom Oct 20, 2020
Merged
Conversation
nic-chen
force-pushed
the
lua-streaminfo-addresses
branch
from
3ac10d1 to
76e2050
Compare
dio
suggested changes
Oct 13, 2020
Member
dio
left a comment
dio
left a comment
There was a problem hiding this comment.
Thanks, looks good.
I think you need to add an entry to docs/root/version_history/current.rst telling that we are adding these two new APIs as "New Features" (there is a couple of examples of Lua changes entries in, e.g. docs/root/version_history/v1.8.0.rst)
nic-chen
force-pushed
the
lua-streaminfo-addresses
branch
3 times, most recently
from
97101be to
3a6400e
Compare
Member
|
@nic-chen, sorry, after applying my suggestion here: #13536 (comment) could you merge main? 🙏🏽 |
nic-chen
force-pushed
the
lua-streaminfo-addresses
branch
from
3460ce4 to
2bb0682
Compare
…moteAddress for Lua filter Signed-off-by: nic-chen <johz@163.com>
Signed-off-by: nic-chen <johz@163.com>
…ectRemoteAddress` into one Signed-off-by: nic-chen <johz@163.com>
Signed-off-by: nic-chen <johz@163.com>
Signed-off-by: nic-chen <johz@163.com>
Signed-off-by: nic-chen <johz@163.com>
Contributor
Author
done. |
nic-chen
force-pushed
the
lua-streaminfo-addresses
branch
from
6e9f90e to
dfe3168
Compare
Signed-off-by: nic-chen <johz@163.com>
Signed-off-by: nic-chen <johz@163.com>
nic-chen
force-pushed
the
lua-streaminfo-addresses
branch
from
dfe3168 to
b9d34e7
Compare
dio
reviewed
Oct 16, 2020
Member
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
Member
|
@nic-chen I think you can do merge master instead of rebasing your branch with the master (so you don't have to do force-pushing). I can see from here (#13536 (comment)): You haven't merged the master branch into yours, since we have removed |
Contributor
Author
|
@dio |
Signed-off-by: nic-chen <johz@163.com>
dio
reviewed
Oct 16, 2020
Signed-off-by: nic-chen <johz@163.com>
dio
reviewed
Oct 16, 2020
mattklein123
approved these changes
Oct 20, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 21, 2020
* master: (22 commits) ci: various improvements (envoyproxy#13660) dns: fix defunct fd bug in apple resolver (envoyproxy#13641) build: support ppc64le with wasm (envoyproxy#13657) [fuzz] Added random load balancer fuzz (envoyproxy#13400) dependencies: compute and check release dates via GitHub API. (envoyproxy#13582) mac ci: try ignoring update failure (envoyproxy#13658) watchdog: Optimize WatchdogImpl::touch in preparation to more frequent petting of the watchdog. (envoyproxy#13103) typos: fix a couple 'enovy' mispellings (envoyproxy#13645) lua: Expose stream info downstreamLocalAddress and downstreamDirectRemoteAddress for Lua filter (envoyproxy#13536) tap: fix upstream streamed transport socket taps (envoyproxy#13638) Revert "delay health checks until transport socket secrets are ready. (envoyproxy#13516)" (envoyproxy#13639) Watchdog: use abort action as a default if killing is enabled. (envoyproxy#13523) [fuzz] Fixed divide by zero bug (envoyproxy#13545) wasm: flip the meaning of the "repository" in envoy_wasm_cc_binary(). (envoyproxy#13621) fix: record recovered local address (envoyproxy#13581) docs: fix incorrect compressor filter doc (envoyproxy#13611) docs: clean up docs for azp migration (envoyproxy#13558) wasm: fix building Wasm example. (envoyproxy#13619) test: Refactor flood tests into a separate test file (envoyproxy#13556) wasm: re-enable tests with precompiled modules. (envoyproxy#13583) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Client IP should be very commonly used and helpful for users.
Expose
downstreamLocalAddressanddownstreamDirectRemoteAddresshelp us get client IP in Lua filters.Risk Level: Low
Testing: Modify unit test
Docs Changes: updated Lua filter doc
Release Notes: N/A
Fixes #13457
Signed-off-by: nic-chen johz@163.com