ci: fix python version used in mac virtual env#13472
Closed
instagrim-dev wants to merge 4 commits intoenvoyproxy:masterfrom
Closed
ci: fix python version used in mac virtual env#13472instagrim-dev wants to merge 4 commits intoenvoyproxy:masterfrom
instagrim-dev wants to merge 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Jonathan Maye-Hobbs <jonmhobbs@gmail.com>
instagrim-dev
force-pushed
the
mac_ci_pythonfix
branch
from
1050334 to
596cc7c
Compare
lizan
previously approved these changes
Oct 9, 2020
Member
|
@wheelpharaoh the macOS failure seems legit |
Signed-off-by: Jonathan Maye-Hobbs <jonmhobbs@gmail.com>
indeed. |
Signed-off-by: Jonathan Maye-Hobbs <jonmhobbs@gmail.com>
Member
|
FYI #13485 should fix the issue |
Signed-off-by: Jonathan Maye-Hobbs <jonmhobbs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: pin python for mac virtualenv
Additional Description: pin python to 3.8; remove superfluous pip install of slackclient, outside virtualenv
Risk Level: low
Testing: manual
Docs Changes: N/A
Release Notes: N/A