docs/ci: Update config validation#13387
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Oct 5, 2020
Merged
Conversation
phlax
changed the title
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-config-validation
branch
2 times, most recently
from
0dc600a to
d48d2ae
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-config-validation
branch
from
d628975 to
48b24d5
Compare
phlax
changed the title
phlax
commented
Oct 5, 2020
phlax
force-pushed
the
docs-config-validation
branch
2 times, most recently
from
b53f3f2 to
3f914af
Compare
Member
Author
|
/retest-circle |
|
🤷♀️ nothing to rebuild. |
phlax
force-pushed
the
docs-config-validation
branch
from
3f914af to
3457b52
Compare
Member
Author
mattklein123
requested changes
Oct 5, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Amazing, thanks. Just one small question/comment.
/wait
Signed-off-by: Ryan Northey <ryan@synca.io>
lizan
pushed a commit
that referenced
this pull request
Oct 16, 2020
some configs in docs were initially excluded from validation (in #13387) - this PR will remove the exclusions where possible Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: docs/ci: Update config validation
Additional Description:
.rstfiles, some of these can be checked with config validation (with some small modifications). Some fail - so will follow up in subsequent PR to address failing configsexamples/BUILDverify_build_configsas configs are found dynamicallyRisk Level: low
Testing: yep
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]