extensions: add explicit type annotation for absl::optional#13338
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 30, 2020
Merged
extensions: add explicit type annotation for absl::optional#13338mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
When compiling Envoy Mobile locally, I was seeing the following error without this change: ``` external/envoy/source/extensions/transport_sockets/tls/ocsp/asn1_utility.cc:37:23: error: no viable constructor or deduction guide for deduction of template arguments of 'optional' return is_present ? absl::optional(data) : absl::nullopt; ``` Signed-off-by: Michael Rebello <me@michaelrebello.com>
mattklein123
approved these changes
Sep 30, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Confused how this compiled before but ... C++. Thanks!
Contributor
|
Is Envoy Mobile using C++17? I assume this worked before because of template deduction guides. |
Contributor
Author
|
Yep it is using C++17. I'm not really clear on why this only seems to break there either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling Envoy Mobile locally, I was seeing the following error without this change:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Signed-off-by: Michael Rebello me@michaelrebello.com