coverage: allow overriding coverage threshold#13236
Merged
junr03 merged 1 commit intoenvoyproxy:masterfrom Sep 23, 2020
junr03:cov-threshold
Merged
coverage: allow overriding coverage threshold#13236junr03 merged 1 commit intoenvoyproxy:masterfrom junr03:cov-threshold
junr03 merged 1 commit intoenvoyproxy:masterfrom
junr03:cov-threshold
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
ggreenway
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: allow overriding coverage threshold
Additional Description: allows third party runners (like Envoy Mobile) to set their own coverage thresholds independent of Envoy's threshold.
Risk Level: low - nothing changing in the Envoy CI run.
Testing: CI, and tested overriding in Envoy Mobile.
Signed-off-by: Jose Nino jnino@lyft.com