lua: Make httpCall to return raw data#13199
Merged
dio merged 4 commits intoenvoyproxy:masterfrom Sep 22, 2020
dio:lua-httpcall-response
Merged
lua: Make httpCall to return raw data#13199dio merged 4 commits intoenvoyproxy:masterfrom dio:lua-httpcall-response
dio merged 4 commits intoenvoyproxy:masterfrom
dio:lua-httpcall-response
Conversation
This patch lets httpCall to return raw data, hence full response body can be accessed from Lua script. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
requested changes
Sep 21, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM. I think this should at least have a release note? This seems like a bug fix but it is technically a behavior change.
/wait
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This patch lets
httpCallto return raw data, hence a full response body can be accessed from Lua script.Risk Level: Low
Testing: Modify unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #10048
Signed-off-by: Dhi Aurrahman dio@tetrate.io