Split verify_examples tests#13195
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Sep 21, 2020
Merged
Conversation
This allows you to run `verify_build_configs` and `run_examples` independently, making it easier to verify an added sandbox locally. Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
dio
previously approved these changes
Sep 21, 2020
Member
dio
left a comment
dio
left a comment
There was a problem hiding this comment.
I was about to ask a better "printing help" facility. But, tried running it myself, this one is good enough for now.
Looks good. Thanks!
Signed-off-by: Ryan Northey <ryan@synca.io>
dio
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples/ci: spit verify_examples tests
Additional Description:
This allows you to run
verify_build_configsandrun_examplesindependently,making it easier to verify an added sandbox locally.
Risk Level: low
Testing: yep
Docs Changes: to follow
Release Notes:
[Optional Runtime guard:] touch #13084
[Optional Fixes #Issue]
[Optional Deprecated:]