Skip to content

build: enable -Wrange-loop-analysis rule #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rebello95 wants to merge 5 commits into from
Closed

build: enable -Wrange-loop-analysis rule #13184

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e15eb9
build: enable -Wrange-loop-analysis rule
rebello95 Sep 18, 2020
8ba63c3
Merge remote-tracking branch 'origin/master' into range-loop-enable
rebello95 Sep 18, 2020
62468dc
Merge remote-tracking branch 'origin/master' into range-loop-enable
rebello95 Sep 21, 2020
a6bf854
violation
rebello95 Sep 21, 2020
ddb288a
fixup
rebello95 Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bazel/envoy_internal.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def envoy_copts(repository, test = False):
"-Wold-style-cast",
"-Wformat",
"-Wformat-security",
"-Wrange-loop-analysis",
"-Wvla",
]

Expand Down
2 changes: 1 addition & 1 deletion source/extensions/filters/http/common/compressor/compressor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ CompressorFilter::chooseEncoding(const Http::ResponseHeaderMap& headers) const {
}

// Find all encodings accepted by the user agent and adjust the list of allowed compressors.
for (const auto token : StringUtil::splitToken(*accept_encoding_, ",", false /* keep_empty */)) {
for (const auto& token : StringUtil::splitToken(*accept_encoding_, ",", false /* keep_empty */)) {
EncPair pair =
std::make_pair(StringUtil::trim(StringUtil::cropRight(token, ";")), static_cast<float>(1));
const auto params = StringUtil::cropLeft(token, ";");
Expand Down