ssl: split out client (config) context, small cleanups.#1318
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Jul 24, 2017
Merged
ssl: split out client (config) context, small cleanups.#1318htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
* To support the TLS context stuff in the v2 CDS update, we need to cleanly distinguish between client, server and common context. * Constify various members of ContextConfigImpl etc.
PiotrSikora
reviewed
Jul 24, 2017
include/envoy/ssl/context_manager.h
Outdated
|
|
||
| /** | ||
| * Builds an ClientContext from an ContextConfig | ||
| * Builds an ClientContext from a Client ContextConfig. |
Contributor
There was a problem hiding this comment.
Nit: ClientContextConfig.
mattklein123
previously approved these changes
Jul 24, 2017
mattklein123
approved these changes
Jul 24, 2017
PiotrSikora
approved these changes
Jul 24, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…yproxy#1318) Automatic merge from submit-queue. Use StopIterationAndWatermark instead of StopIterationAndBuffer **What this PR does / why we need it**:Do not buffer request body during Mixer Check() call. This is to avoid buffer overflow when POST request has large body and Mixer filter is waiting for Check() response. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1315 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Adds an iterator to the `Headers` classes to iterate through headers. Note that this violates C++ design by iterating through the header key, not the header key/value pair. I chose this design because `pybind11` was giving me invalid memory access errors while trying to iterate through pairs. Risk Level: Low Testing: Pending Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Adds an iterator to the `Headers` classes to iterate through headers. Note that this violates C++ design by iterating through the header key, not the header key/value pair. I chose this design because `pybind11` was giving me invalid memory access errors while trying to iterate through pairs. Risk Level: Low Testing: Pending Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
…urityPolicyIndexFunc (#1318) **Description** The `backendSecurityPolicyIndexFunc` is missing cases for Azure apikey and credential types. This is causing the controller to not update the ai-gateway proxy on changes to watched resources, e.g. secrets. **Related Issues/PRs (if applicable)** Fixes: #1313 Signed-off-by: Tim Swanson <tiswanso@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support the TLS context stuff in the v2 CDS update, we need to cleanly distinguish between
client, server and common context.
Constify various members of ContextConfigImpl etc.