Shellcheck: ci/ (2)

[phlax]

Commit Message: Shellcheck: ci/
Additional Description:
2nd attempt at linting ci directory

address problem with clang_tidy compiler

Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #7793
[Optional Deprecated:]

[phlax]

i have reproduced the error with the clang_tidy compilation, and fixed the problem.

Im wondering if there are any other changes i should make to test everything is working - i could not see anywhere else in do_ci.sh with the same issue

[asraa]

Im wondering if there are any other changes i should make to test everything is working

Matt brought up that testing with an empty code change will trigger clang_tidy to run (where before it thinks there is an empty diff) to test in CI. Otherwise I think the tests should be running without caching (bazel.release, asan, tsan, etc).

And thank you!!

[phlax]

Matt brought up that testing with an empty code change will trigger clang_tidy to run (where before it thinks there is an empty diff) to test in CI.

i think i did that - if you check the commits - and the clang_tidy script failed - i reverted it after. Unless im misunderstanding

[phlax]

there seems to be a problem with coverage - trying to figure it out...

[phlax]

there seems to be a problem with coverage

this seem to have been a flakey test - adding another commit or amending the failing one fixed the problem

[zuercher]

Thanks. I think I found one more, but otherwise lgtm.