rbac: expose filter state#13163
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
| } | ||
|
|
||
| protected: | ||
| ProtobufWkt::Arena* arena_; |
There was a problem hiding this comment.
serializeString returns a string by value, so a copy is made on this arena, because CelValue takes const string*.
There was a problem hiding this comment.
Maybe I'm missing something, but this looks like just a pointer to the arena that gets assigned above, how is the copy done?
There was a problem hiding this comment.
arena_ is used in the implementation of the wrapper. The base class is shared with other wrappers, which is how it gets passed down. I am working on making this flow better upstream, and get rid of the arena use in this case, but it's not simple.
| ProtobufWkt::Arena arena; | ||
| wrapper.Produce(&arena); | ||
|
|
||
| const auto key = "filter_state_key"; |
There was a problem hiding this comment.
Nit: prefer making string types explicit rather than too much auto.
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
/retest |
3 participants
Commit Message: expose filter state values to CEL context. This uses string serialization due to better efficiency.
Risk Level: low (opt-in)
Testing: unit
Docs Changes: yes
Release Notes: no