test: use test-only resource monitor in overload manager integration test#13135
Merged
antoniovicente merged 4 commits intoenvoyproxy:masterfrom Sep 21, 2020
Merged
test: use test-only resource monitor in overload manager integration test#13135antoniovicente merged 4 commits intoenvoyproxy:masterfrom
antoniovicente merged 4 commits intoenvoyproxy:masterfrom
Conversation
Remove the dependence on the injected_resource build target target that can be disabled. Signed-off-by: Alex Konradi <akonradi@google.com>
Fix the issue identified by the formatter by registering the factory using InjectFactory instead of static registration. Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for helping minimize the number of core test dependencies on extensions.
Change looks pretty good, just some minor nits.
More asserts, less conditional behavior, inline member with one usage Signed-off-by: Alex Konradi <akonradi@google.com>
antoniovicente
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: remove overload manager integration test dependence on injected_resource monitor
Additional Description:
Remove the dependence on the injected_resource build target target that
can be disabled via the extension system.
Risk Level: low
Testing: ran integration test
Docs Changes: none
Release Notes: none