ext_authz: Allow to send request body as raw bytes#13131
Merged
mattklein123 merged 15 commits intoenvoyproxy:masterfrom Sep 22, 2020
dio:raw-body
Merged
ext_authz: Allow to send request body as raw bytes#13131mattklein123 merged 15 commits intoenvoyproxy:masterfrom dio:raw-body
mattklein123 merged 15 commits intoenvoyproxy:masterfrom
dio:raw-body
Conversation
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
htuch
reviewed
Sep 16, 2020
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
requested changes
Sep 17, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for fixing this long standing issue. One high level API comment to get started. Thank you!
/wait
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Sorry one more API question before the full review.
/wait-any
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
requested changes
Sep 21, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thanks. LGTM with one possible simplification. Thank you!
/wait
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
requested changes
Sep 22, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with small comment.
/wait
pnnferreira
referenced
this pull request
in pnnferreira/opa-envoy-plugin
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This patch allows to send request body as raw bytes to the external authorization server.
Risk Level: Low
Testing: Unit
Docs Changes: Added
Release Notes: Added
Fixes #9822