[Windows] Fixes UDS integration & caches socket domain#13123
[Windows] Fixes UDS integration & caches socket domain#13123mattklein123 merged 14 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
cc: @envoyproxy/windows-dev |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
/wait For defaults resolution |
|
@wrowe marking it as a draft to query some full builds in the CI to figure out which consumers are setting the default value for |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
@wrowe i expect the ci to go green and it should be ready for review |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
|
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
@envoyproxy/senior-maintainers can I also get a review from you. |
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comments, thanks.
/wait
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
Looks like and working in simplifying the |
|
If it forces it and is a bug in the formatter don't worry about it. |
|
Actually it is easy to fix if you simplify the functions above so it might be an overall win. I just transformed the Verifying my changes and pushing another commit |
…ddressFromHeader Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
WDYT of the changes in 509d1c3? Locally it fixes my |
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
@mattklein123 the CI is all green again. feel free to take a look at the last 2 commits when you get some time. |
Commit Message:
The PR aims to fix UDS integration tests on Windows. To that end the following changes were made:
domainfunction usage on Windows by caching the domain from the socket creation and passing down to the io_handler.Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A