Shellcheck: bazel/ examples/ and other remaining linting issues

[phlax]

Commit Message: Shellcheck: bazel/ examples/
Additional Description:
Remaining shellcheck cleanups
Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] fixes #7793
[Optional Deprecated:]

[phlax]

im wondering if this will handle multiline output from find correctly

[zuercher]

I don't think it does:

$ printf "1: %s, 2: %s\n" $(printf "a\nb\n")
1: a, 2: b
$ printf "1: %s, 2: %s\n" "$(printf "a\nb\n")"
1: a
b, 2: 

[phlax]

which without readarray means this i think

$ _args="$(printf "a\nb\n")"
$ while read -r line; do args+=("$line"); done \
    <<< "$_args"
$ printf "1: %s, 2: %s\n" "${args[@]}"
1: a, 2: b

[phlax]

im thinking that #12889 should probably land before this one as i think one or other will need to rebase

[zuercher]

This looks good to me. Do you want to hold it until #12889 lands?

[phlax]

This looks good to me. Do you want to hold it until #12889 lands?

yep waiting...

8)

[phlax]

/azp run

[azure-pipelines]

Command 'rerun' is not supported by Azure Pipelines.

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[azure-pipelines]

Commenter does not have sufficient privileges for PR 13106 in repo envoyproxy/envoy

[zuercher]

Is this ready to go now?

[phlax]

yep