[Windows] Adds a native windows filesystem implementation#13077
Merged
mattklein123 merged 10 commits intoenvoyproxy:masterfrom Sep 21, 2020
Merged
[Windows] Adds a native windows filesystem implementation#13077mattklein123 merged 10 commits intoenvoyproxy:masterfrom
mattklein123 merged 10 commits intoenvoyproxy:masterfrom
Conversation
…entation Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
cc: @envoyproxy/windows-dev gimme one CI run to clean up any formatting or cascading build errors |
nigriMSFT
reviewed
Sep 14, 2020
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
wrowe
reviewed
Sep 16, 2020
Contributor
wrowe
left a comment
There was a problem hiding this comment.
A couple quick comments for discussion, but generally looking really good here, thanks!
added 5 commits
September 16, 2020 11:10
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
Attempting to bump coverage above threshold. Technically it shouldn't have been affected by the change since the code is a null-op in linux. |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
|
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
@envoyproxy/senior-maintainers can I also get a review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
Refactor
filesystem_implto use win32 APIs instead of POSIX subsystem. Fixes issue #11655.Additional Description:
For easier review the major changes are the following:
file_shared_implbecause it relied onerrnofor error handling. This change cascades to the POSIX implementationRisk Level: Low
Testing: Already tested in
filesystem_impl_testDocs Changes: N/A
Release Notes: N/A