quiche: update tar ball to f555d99a084cdd086a349548c70fb558ac5847cf#13066
Merged
ggreenway merged 9 commits intoenvoyproxy:masterfrom Sep 18, 2020
Merged
quiche: update tar ball to f555d99a084cdd086a349548c70fb558ac5847cf#13066ggreenway merged 9 commits intoenvoyproxy:masterfrom
ggreenway merged 9 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @wu-bin @alyssawilk |
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
wu-bin
previously approved these changes
Sep 14, 2020
bazel/external/quiche.BUILD
Outdated
| "-Wno-ignored-qualifiers", | ||
| "-Wno-sign-compare", | ||
| "-Wno-inconsistent-missing-override", | ||
| "-Wno-unused-function", |
Member
|
@danzh2010 there's a gcc CI failure in quiche (not envoy) code. /wait |
Member
|
gcc is still broken in quiche /wait |
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
|
This looks good now on gcc @ggreenway @danzh2010 TYVM! |
danzh2010
changed the title
Contributor
Author
|
Had to fix more in upstream, PTAL |
Contributor
|
As this is a blocking issue for other PR's we would ask @envoyproxy/senior-maintainers if anyone has cycles to give this a green light and pull it? |
ggreenway
approved these changes
Sep 18, 2020
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making all the fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Zhang danzh@google.com
Update QUICHE to commit f555d99a084cdd086a349548c70fb558ac5847cf to fix some Windows compilation errors.
Remove EnvoyCryptoServerStream interface because it was there purely to accessing proof source in quic:: QuicCryptoServerStream and quic:: TlsServerHandshaker. Now that QUICHE provide a common interface for these two to expose ProofSource object, we don't need to override them to obtain and access the proof source any more. Remove the envoy subclasses EnvoyQuicCryptoServerStream and EnvoyQuicTlsServerHandshaker.
Fixes #10420, #13154