tracer: Add SkyWalking tracer by wbpcode · Pull Request #13060 · envoyproxy/envoy

wbpcode · 2020-09-11T13:24:33Z

Commit Message: Tracer: new tracer for SkyWalking tracing
Additional Description:
A new tracer to support SkyWalking Tracing. Check issue #12486 for more information.

This work is based on @dio 's initial code. It is a great job and is very helpful for me to start this work. Thanks.

Complete docker-compose sandbox to test SkyWalking tracer.

Risk Level: Medium
Testing: unit test & need more test
Docs Changes: None.
Release Notes: None.

Signed-off-by: wbpcode <comems@msn.com>

repokitteh-read-only · 2020-09-11T13:24:40Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.
CC @envoyproxy/dependency-watchers: FYI only for changes made to (bazel/repository_locations\.bzl)|(api/bazel/repository_locations\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13060 was opened by wbpcode.

see: more, trace.

dio · 2020-09-11T13:28:48Z

cc. @yskopets

CODEOWNERS

Signed-off-by: wbpcode <comems@msn.com>

lizan

quick api review

api/envoy/config/trace/v3/skywalking.proto

Signed-off-by: wbpcode <comems@msn.com>

wbpcode · 2020-09-22T11:13:27Z

/retest

repokitteh-read-only · 2020-09-22T11:13:31Z

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13060 (comment) was created by @wbpcode.

see: more, trace.

CODEOWNERS

source/extensions/extensions_build_config.bzl

dio · 2020-09-22T13:12:11Z

@wbpcode do you think this is ready to review? I'll try to create a test repo (docker-compose) for this tomorrow morning so we can have a sandbox for this.

wbpcode · 2020-09-22T13:59:36Z

@wbpcode do you think this is ready to review? I'll try to create a test repo (docker-compose) for this tomorrow morning so we can have a sandbox for this.

@dio

Yes. I think it is ready to review. I did some simple manual tests in our own environment. But we use the Envoy version that we maintain independently, which is not exactly the same as the community version. And our SkyWalking is also an internal version, which is also different from the community. 😢

This will be great if you complete this sandbox. 😄

Signed-off-by: wbpcode <comems@msn.com>

dio · 2020-09-30T23:29:07Z

cc. @basvanbeek

source/extensions/tracers/skywalking/tracer.cc

source/extensions/tracers/skywalking/tracer.h

test/extensions/tracers/skywalking/skywalking_client_config_test.cc

test/extensions/tracers/skywalking/tracer_test.cc

Signed-off-by: wbpcode <comems@msn.com>

wbpcode · 2020-11-01T06:48:33Z

@lizan Updated again. 😄 If there's anything else that needs to be optimized, just ask and I'll fix it as soon as possible.

lizan

Thanks, just two style stuff for all the tests.

test/extensions/tracers/skywalking/skywalking_client_config_test.cc

Signed-off-by: wbpcode <comems@msn.com>

…walking

wbpcode · 2020-11-02T08:48:11Z

~~@htuch It's done. Thanks for your patience and care. 🌹 🌹 🌹~~
@htuch Sorry, I look @ the wrong person. I still appreciate your suggestions and help during the API review process of this PR. Thanks.

…walking

Signed-off-by: wbpcode <comems@msn.com>

wbpcode · 2020-11-03T03:17:29Z

/retest

repokitteh-read-only · 2020-11-03T03:17:33Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13060 (comment) was created by @wbpcode.

see: more, trace.

Signed-off-by: wbpcode <comems@msn.com>

test/extensions/tracers/skywalking/skywalking_test_helper.h

Signed-off-by: wbpcode <comems@msn.com>

wbpcode · 2020-11-03T06:20:58Z

@lizan It‘s done now. Thank you very much for your patient review. 👍

wbpcode · 2020-11-03T11:47:37Z

@moderation Hello, it's almost over now. Hope you can confirm that deps is ok.

moderation · 2020-11-03T15:43:18Z

api/bazel/repository_locations.bzl

+        project_name = "SkyWalking API",
+        project_desc = "SkyWalking's language independent model and gRPC API Definitions",
+        project_url = "https://github.com/apache/skywalking-data-collect-protocol",
+        version = "8.1.0",


8.2.0 is out at https://github.com/apache/skywalking-data-collect-protocol/releases/tag/v8.2.0. Do you want to bump here or do as a follow up?

8.1.0 and 8.2.0 are the same for the tracing format of the language agent. I think it is fine.
SkyWalking wouldn't break the tracing format for a long time to keep all language agents compatible and LTS.

If this is an envoy project requirement, @wbpcode the 8.1.0->8.2.0 should not break anything you wrote :)

moderation · 2020-11-03T15:48:12Z

/lgtm deps

I have more accurate release_date checking code now and will review with Harvey upon his return. The new code outputs the following. There are quite a few dates that need to be corrected and I can fix in a follow up.

github_release:  GitHubRelease(organization='apache', project='skywalking-data-collect-protocol', version='v8.1.0', tagged=True)
release_date:  2020-07-31 12:53:06
*WARNING* com_github_apache_skywalking_data_collect_protocol has a newer release than v8.1.0@<2020-07-31 12:53:06>: v8.2.0@<2020-09-08 08:47:35>
com_github_apache_skywalking_data_collect_protocol has a GitHub release date 2020-07-31
An error occurred while processing api/bazel/repository_locations.bzl, please verify the correctness of the metadata: Mismatch with metadata release date of 2020-07-29

dio

Thanks!

Commit Message: update docs for skywalking tracer Additional Description: Add some docs for SkyWalking tracer. This is a supplement for #13060. It has been delayed until now for personal reasons. Risk Level: Low Testing: N/A Docs Changes: Docs Only Release Notes: N/A Platform Specific Features: N/A Signed-off-by: wbpcode <comems@msn.com>

wbpcode added 2 commits September 11, 2020 21:15

initial code from @dio

74e0892

Signed-off-by: wbpcode <comems@msn.com>

Tracer: support SkyWalking tracing report

f384820

Signed-off-by: wbpcode <comems@msn.com>

repokitteh-read-only bot added the api label Sep 11, 2020

dio marked this pull request as draft September 11, 2020 13:30

htuch assigned dio and lizan Sep 11, 2020

htuch reviewed Sep 11, 2020

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

wbpcode added 7 commits September 13, 2020 01:11

add simple stats to skywalking tracer

b8ce5a3

Signed-off-by: wbpcode <comems@msn.com>

add more test for skywalking

f95f9dd

Signed-off-by: wbpcode <comems@msn.com>

Merge branch 'master' of github.com:envoyproxy/envoy into skywalking

f44d946

fix http tracer impl test

bf033d8

Signed-off-by: wbpcode <comems@msn.com>

fix clang tidy check

348387e

Signed-off-by: wbpcode <comems@msn.com>

use authentication as token key

d689a88

Signed-off-by: wbpcode <comems@msn.com>

peer address looks like downstream adddress

3dcb800

Signed-off-by: wbpcode <comems@msn.com>

lizan reviewed Sep 17, 2020

View reviewed changes

api/envoy/config/trace/v3/skywalking.proto Outdated Show resolved Hide resolved

api/envoy/config/trace/v3/skywalking.proto Outdated Show resolved Hide resolved

wbpcode added 2 commits September 18, 2020 13:29

use request host as peer address for exit span

5583faf

Signed-off-by: wbpcode <comems@msn.com>

add more test to cover more code

bd16737

Signed-off-by: wbpcode <comems@msn.com>

dio reviewed Sep 22, 2020

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

dio reviewed Sep 22, 2020

View reviewed changes

source/extensions/extensions_build_config.bzl Outdated Show resolved Hide resolved

dio changed the title ~~[WIP] Tracer: new tracer for SkyWalking tracing~~ tracer: Add SkyWalking tracer Sep 22, 2020

wbpcode added 3 commits September 25, 2020 19:59

minor change

44a954f

Signed-off-by: wbpcode <comems@msn.com>

add backoff strategy

6bef0f4

Signed-off-by: wbpcode <comems@msn.com>

fix format

7c05904

Signed-off-by: wbpcode <comems@msn.com>

lizan reviewed Oct 31, 2020

View reviewed changes

remove global static std::string and some minor update

8fa92a2

Signed-off-by: wbpcode <comems@msn.com>

lizan reviewed Nov 1, 2020

View reviewed changes

test/extensions/tracers/skywalking/skywalking_client_config_test.cc Outdated Show resolved Hide resolved

test/extensions/tracers/skywalking/skywalking_client_config_test.cc Show resolved Hide resolved

wbpcode added 2 commits November 2, 2020 12:44

remove using namespace & wrap test by anonymous namespace

fdc58a0

Signed-off-by: wbpcode <comems@msn.com>

Merge branch 'master' of https://github.com/envoyproxy/envoy into sky…

b93d3ff

…walking

wbpcode added 2 commits November 3, 2020 08:43

Merge branch 'master' of https://github.com/envoyproxy/envoy into sky…

675f634

…walking

fix docs after merge master

f95b77d

Signed-off-by: wbpcode <comems@msn.com>

Kick CI

6aab97c

Signed-off-by: wbpcode <comems@msn.com>

lizan reviewed Nov 3, 2020

View reviewed changes

test/extensions/tracers/skywalking/skywalking_test_helper.h Outdated Show resolved Hide resolved

anonymous namespace in header

fe43441

Signed-off-by: wbpcode <comems@msn.com>

lizan approved these changes Nov 3, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Nov 3, 2020

dio requested a review from moderation November 3, 2020 11:38

moderation reviewed Nov 3, 2020

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 3, 2020

dio approved these changes Nov 4, 2020

View reviewed changes

dio merged commit 7d0f89b into envoyproxy:master Nov 4, 2020

wbpcode mentioned this pull request Nov 30, 2020

Update docs for skywalking tracer #14210

Merged

Conversation

wbpcode commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Sep 11, 2020

Uh oh!

dio commented Sep 11, 2020

Uh oh!

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Sep 22, 2020

Uh oh!

repokitteh-read-only bot commented Sep 22, 2020

Uh oh!

Uh oh!

Uh oh!

dio commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wbpcode commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dio commented Sep 30, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Nov 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Nov 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wbpcode commented Nov 3, 2020

Uh oh!

repokitteh-read-only bot commented Nov 3, 2020

Uh oh!

Uh oh!

wbpcode commented Nov 3, 2020

Uh oh!

wbpcode commented Nov 3, 2020

Uh oh!

moderation Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

wu-sheng Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

wu-sheng Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

moderation commented Nov 3, 2020

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

wbpcode commented Sep 11, 2020 •

edited

Loading

dio commented Sep 22, 2020 •

edited

Loading

wbpcode commented Sep 22, 2020 •

edited

Loading

wbpcode commented Nov 1, 2020 •

edited

Loading

wbpcode commented Nov 2, 2020 •

edited

Loading