Skip to content

coverage: use dynamic link#13045

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
lizan:dynamic_link_coverage
Sep 10, 2020
Merged

coverage: use dynamic link#13045
htuch merged 2 commits intoenvoyproxy:masterfrom
lizan:dynamic_link_coverage

Conversation

@lizan
Copy link
Member

@lizan lizan commented Sep 10, 2020

Commit Message:
Enable dynamic link test for coverage, to save storage / cache.

Risk Level: Low (test only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Also fixes #13020

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
dio
dio previously approved these changes Sep 10, 2020
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think CI approves this 🙂.

@lizan
Copy link
Member Author

lizan commented Sep 10, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13045 (comment) was created by @lizan.

see: more, trace.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 503f4cc into envoyproxy:master Sep 10, 2020
@lizan lizan deleted the dynamic_link_coverage branch September 10, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux-x64 coverage: //test/extensions/filters/network/thrift_proxy:thrift_object_impl_test flake

3 participants