Skip to content

Fix typos in Lua filter documentation; add an example Lua script#13022

Merged
htuch merged 4 commits intoenvoyproxy:masterfrom
plallin:update-lua-filter-doc
Sep 9, 2020
Merged

Fix typos in Lua filter documentation; add an example Lua script#13022
htuch merged 4 commits intoenvoyproxy:masterfrom
plallin:update-lua-filter-doc

Conversation

@plallin
Copy link
Contributor

@plallin plallin commented Sep 9, 2020

Commit Message: This fixes typos in Lua filter documentation and adds an example script.
Additional Description: applying recommendations from: #13010 (comment)

Risk Level: Low, docs only.
Testing: N/A
Docs Changes: Fix typos in Lua filter documentation; added an example script showing how to access request/response information using specific headers.
Release Notes: N/A

Signed-off-by: Pauline pauline.lallinec@gmail.com

Signed-off-by: Pauline <pauline.lallinec@gmail.com>
Signed-off-by: Pauline <pauline.lallinec@gmail.com>
Signed-off-by: Pauline <pauline.lallinec@gmail.com>
@plallin plallin force-pushed the update-lua-filter-doc branch from bb0a79f to b490c69 Compare September 9, 2020 11:28
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Or We can define new Lua script in the LuaPerRoute configuration directly to override `GLOBAL`
Lua script as follow example configuration:
Or we can define a new Lua script in the LuaPerRoute configuration directly to override the `GLOBAL`
Lua script as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you update the "Go Go C Plus Plus." with something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Signed-off-by: Pauline <pauline.lallinec@gmail.com>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit f5fedaa into envoyproxy:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants