docs: Import searchtools.js#13008
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 10, 2020
dio:import-searchtools
Merged
docs: Import searchtools.js#13008htuch merged 1 commit intoenvoyproxy:masterfrom dio:import-searchtools
htuch merged 1 commit intoenvoyproxy:masterfrom
dio:import-searchtools
Conversation
This imports searchtools.js from https://raw.githubusercontent.com/sphinx-doc/sphinx/3.x/sphinx/themes/basic/static/searchtools.js. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
htuch
reviewed
Sep 8, 2020
htuch
approved these changes
Sep 10, 2020
Contributor
|
@dio I was wondering if the Edit: I just noticed #13005 (comment). Are we trying to override / update an existing version of this file beyond what is in Sphinx 3.2.1? |
Member
Author
|
@moderation yes, instead of building a full-theme. We override this to introduce small changes to it. I think when we bump (the major version of) Sphinx, that is the time we need to sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This imports searchtools.js from https://raw.githubusercontent.com/sphinx-doc/sphinx/3.x/sphinx/themes/basic/static/searchtools.js.
Additional Description: #13005 (comment)
Risk Level: None
Testing: CI docs build
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Dhi Aurrahman dio@tetrate.io