Dependencies: dataplane (Thrift) move to pip3 + SHA256 pinning of pip…#12982
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 10, 2020
moderation:master
Merged
Dependencies: dataplane (Thrift) move to pip3 + SHA256 pinning of pip…#12982htuch merged 1 commit intoenvoyproxy:masterfrom moderation:master
htuch merged 1 commit intoenvoyproxy:masterfrom
moderation:master
Conversation
…3 imports Signed-off-by: Michael Payne <michael@sooper.org>
moderation
changed the title
zuercher
approved these changes
Sep 4, 2020
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Thrift part looks good to me. Thanks!
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
Contributor
Author
|
assign @htuch |
Member
|
@moderation LGTM, should I merge this or do you want to do any of the TODOs? |
Contributor
Author
|
@htuch Merge please and I'll do follow up PRs for the TODOs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: moderation michael@sooper.org
Risk Level: Low
Testing:
bazel --nohome_rc test //test/extensions/filters/network/kafka/...bazel --nohome_rc test //test/extensions/filters/network/thrift_proxy/.../cc @htuch, @antoniovicente in case this triggers for Thrift the same issue you had with the Kafka transition to pip3 and @zuercher, @rgs1 because Thrift. I tried to convert the Twitter Thrift stuff to pip3 but couldn't make it work. The code is super old and deprecated. Couldn't get the Finagle protocol bits to be seen by
client.pyandserver.py.Docs Changes:
DEPENDENCY_POLICY.mdif we think this approach is OK (SHA256 pinning of Python requirements.txt #12951 (comment))docs/generate_external_dep_rst.pyas we lose CPE metadata when moving frombazel/repository_location.bzlto pip3 importRelease Notes: none required
Comment: I've included CPE metadata as comments in
bazel/repositories_extra.bzl. I thought this would be better for programmatic inclusion indocs/generate_external_dep_rst.py