Windows: Build lua with 5.2 compatibility#12978
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 9, 2020
greenhouse-org:windows-build-lua-5.2-compat
Merged
Windows: Build lua with 5.2 compatibility#12978mattklein123 merged 2 commits intoenvoyproxy:masterfrom greenhouse-org:windows-build-lua-5.2-compat
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
greenhouse-org:windows-build-lua-5.2-compat
Conversation
As per http://lua-users.org/wiki/MetatableEvents the __pairs metamethod is not available until lua 5.2, luajit/moonjit build lua 5.1. This define was set on Linux/Mac but not Windows. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Member
Author
|
cc @envoyproxy/windows-dev |
dio
reviewed
Sep 4, 2020
| @setlocal | ||
| -@set LJCOMPILE=cl /nologo /c /O2 /W3 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_STDIO_INLINE=__declspec(dllexport)__inline | ||
| +@set LJCOMPILE=cl /nologo /c /W3 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_STDIO_INLINE=__declspec(dllexport)__inline | ||
| +@set LJCOMPILE=cl /nologo /c /W3 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_STDIO_INLINE=__declspec(dllexport)__inline /DLUAJIT_ENABLE_LUA52COMPAT |
Member
There was a problem hiding this comment.
Sorry, just curious, why we remove /O2 here?
Member
Author
There was a problem hiding this comment.
/O2 placed there was being applied to to debug and release build modes, it was removed here to enable us to target it to just release mode and disable optimizations entirely in debug
cc @wrowe
Contributor
There was a problem hiding this comment.
You'll find /O2 is still applied appropriately later in the script, @dio
Member
|
@sunjayBhatia this looks good. However, we need to merge main to pick up a fix. |
….2-compat Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Contributor
|
@dio done, thanks. (Sunjay is on PTO) |
mattklein123
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Windows: Build lua with 5.2 compatibility
Additional Description: As per http://lua-users.org/wiki/MetatableEvents the __pairs metamethod is not available until lua 5.2, luajit/moonjit build lua 5.1. This define was set on Linux/Mac but not Windows.
Risk Level: Low
Testing: Enables 3 failing lua tests on Windows, checked locally on Windows
Docs Changes: N/A
Release Notes: N/A