conn_pool: renames (request -> stream)#12975
Merged
alyssawilk merged 3 commits intoenvoyproxy:masterfrom Sep 9, 2020
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
asraa
reviewed
Sep 8, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks! Is this re-name only targetting the connection pool component (and what about OriginalConnPool?) Otherwise LGTM
| if (host_->cluster().resourceManager(priority_).pendingRequests().canCreate()) { | ||
| ConnectionPool::Cancellable* pending = newPendingRequest(context); | ||
| // This must come after newPendingRequest() because this function uses the | ||
| ConnectionPool::Cancellable* pending = newPendingStream(context); |
Contributor
There was a problem hiding this comment.
I can't comment on the line above this, but will the resource manager's requests also be renamed?
Contributor
Author
|
Yeah, OriginalConnPool is theoretically going away so I had no intent to clean that up. |
asraa
approved these changes
Sep 9, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks for the clarification! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: low (renames)
Testing: tests renamed too
Docs Changes: n/a
Release Notes: n/a