Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set#12945
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Sep 7, 2020
greenhouse-org:windows-allow-override-msvc-cl
Merged
Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set#12945lizan merged 1 commit intoenvoyproxy:masterfrom greenhouse-org:windows-allow-override-msvc-cl
lizan merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:windows-allow-override-msvc-cl
Conversation
Will allow us to cleanly add a clang-cl build in CI Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Member
Author
|
@envoyproxy/windows-dev |
Member
Author
|
@snowp Bill is out this week on vacation |
Member
Author
|
Windows RBE pool might be struggling a little |
lizan
approved these changes
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set
Additional Description: Will allow us to cleanly add a clang-cl build in CI
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A