admin: extract config dump handler to separate class#12942
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Sep 9, 2020
Merged
admin: extract config dump handler to separate class#12942mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
zuercher
requested changes
Sep 2, 2020
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Thanks! Other than the dependencies, I think this looks good.
| "@envoy_api//envoy/config/core/v3:pkg_cc_proto", | ||
| "@envoy_api//envoy/config/endpoint/v3:pkg_cc_proto", | ||
| "@envoy_api//envoy/config/route/v3:pkg_cc_proto", | ||
| "@envoy_api//envoy/extensions/filters/network/http_connection_manager/v3:pkg_cc_proto", |
Member
There was a problem hiding this comment.
At least some of these should be added to the config_dump_handler_lib target, since it directly depends on them. They're obviously being picked up by some transitive dependency, but some future refactoring may break that so I'd rather call them out as direct dependencies.
zuercher
reviewed
Sep 2, 2020
|
|
||
| } // namespace | ||
|
|
||
| ConfigDumpHandler::ConfigDumpHandler(ConfigTracker& configTracker, Server::Instance& server) |
Member
There was a problem hiding this comment.
This configTracker should be config_tracker -- that's what clang-tidy is complaining about.
Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Erica Manno <erica.manno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: extract config dump handler to separate class, as part of refactoring for #5505.
Risk Level: low
Testing: pre-existing tests
Docs Changes: n/a
Release Notes: n/a