tls: replace getX509ExtensionValue#12934
Merged
lizan merged 3 commits intoenvoyproxy:masterfrom Sep 10, 2020
Merged
Conversation
The existing access for X509 extension values is unused in Envoy, but will be used in the near future for detection of certificates with the OCSP must-staple extension (see envoyproxy#12685). The existing implementation, however, assumes that all extension values can be safely decoded with ASN1_get_object, which is incorrect. Here we replace that function with a correct implementation that produces different output (that is, the entire value octet string versus a partially decoded value). We remove (unused) access to extension from Envoy::Ssl::Connection and rename the utility method to insure that downstream projects do not unintentionally consume the altered return values. Risk Level: low, not used in Envoy Testing: moved existing unit tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
davidben
previously approved these changes
Sep 2, 2020
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
davidben
previously approved these changes
Sep 2, 2020
lizan
reviewed
Sep 4, 2020
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
friendly ping @lizan |
lizan
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing access for X509 extension values is unused in Envoy, but
will be used in the near future for detection of certificates with the
OCSP must-staple extension (see #12685). The existing implementation,
however, assumes that all extension values can be safely decoded with
ASN1_get_object, which is incorrect. Here we replace getX509ExtensionValue
with a corrected implementation that produces different output (that is,
the entire value octet string versus a partially decoded value). We
remove (unused) access to extensions from Envoy::Ssl::Connection and
rename the utility method to insure that downstream projects do not
unintentionally consume the altered return value.
Risk Level: low, not used in Envoy
Testing: moved existing unit tests
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com