Changed Profile Action to have a per-process limit rather than per thread#12897
Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom Sep 9, 2020
Merged
Conversation
… a per thread limit. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/assign @antoniovicente |
Member
|
Can you add some motivation for this to the commit message? API changes LGTM, since this is v3alpha. |
Member
|
/lgtm api |
antoniovicente
approved these changes
Sep 3, 2020
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Contributor
Author
|
PTAL @envoyproxy/senior-maintainers |
Member
|
@snowp can you assign a non-Googler senior maintainer? Thanks. |
ggreenway
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message: Simplified Profile Action to have a per-process limit rather than a per thread limit which simplifies disk-filling concerns.
Additional Description: We want to prevent the profiler from filling the disk, and using a per thread limit creates more complexity and profiles (i.e. for the "global" limit would be
#threads * limit per threadvslimit per process. The former is harder to reason about.Risk Level: low
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]