-
Notifications
You must be signed in to change notification settings - Fork 5.5k
http: add CDN-Loop header value parser and utilities #12894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 37 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
1a60bd9
http: add CDN-Loop header value parser and utilities
justin-mp 308efac
Fix up style issues
justin-mp 2ef7b2e
Remove designated initializers
justin-mp 734288b
Add an ownership directory for http/cdn
justin-mp 5d1f5f5
Add alyssawilk as code owner for now
justin-mp 53ce984
Make logging output not look like a designated initializer
justin-mp 40b62fb
Teach the spell checker about CDNs
justin-mp 786c47d
Teach the spell checker about more RFC terms
justin-mp 2ee7ced
clang-tidy fixes
justin-mp aef2b60
Merge branch 'master' into cdn-loop-parser
justin-mp 72d7de4
Rename bazel targets to match Envoy naming convention
justin-mp 874ca27
First pass at @penguingao’s comments
justin-mp 155d65a
Add better token error suggested by @penguingao
justin-mp 61f65b3
Clean up parseCdnId as suggested by @penguingao
justin-mp 2712cc7
Move StatusHelpers to test/test_common
justin-mp 41d0df7
Rename update as per comments from @penguingao
justin-mp a48d4a2
Expand comment on why parsing by token is OK.
justin-mp 8574436
Rename the cdn directory to cdn_loop
justin-mp c53f7e8
Make file names less stuttery
justin-mp c81acbf
Clean up namespaces
justin-mp a5627cb
Merge branch 'master' into cdn-loop-parser
justin-mp 9280112
Remove renamed file
justin-mp 0dc94b3
Comment tense police
justin-mp 6caa904
Transposed numbers police
justin-mp 9ad718d
Comment police
justin-mp 89c0ab3
Rename parseOptionalWhitespace to skipOptionalWhitespace
justin-mp be8d21a
Optimize IPv6 and quoted string paths
justin-mp bdde63d
Fix copy pasta from test
justin-mp 410b78e
Wrong word police
justin-mp c734c91
Increase test coverage for parseQuotedString
justin-mp d93ba73
Increase test coverage for parseCdnId
justin-mp 429f4e5
Increase test coverage for parseParameter
justin-mp a9a2c77
Increase test coverage for parseCdnInfoList
justin-mp b6b3764
Increase test coverage for countCdnLoopOccurrences
justin-mp 2e95d94
Increase test coverage of parser.h
justin-mp 4428c59
Make error messages consistent.
justin-mp 3145556
Merge branch 'master' into cdn-loop-parser
justin-mp e3eae40
Missed rename of cdn to cdn_loop
justin-mp a47b097
Fix style failure (std::string_view versus absl::string_view)
justin-mp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| load( | ||
| "//bazel:envoy_build_system.bzl", | ||
| "envoy_cc_library", | ||
| "envoy_extension_package", | ||
| ) | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| envoy_extension_package() | ||
|
|
||
| envoy_cc_library( | ||
| name = "parser_lib", | ||
| srcs = ["parser.cc"], | ||
| hdrs = ["parser.h"], | ||
| deps = ["//source/common/common:statusor_lib"], | ||
| ) | ||
|
|
||
| envoy_cc_library( | ||
| name = "utils_lib", | ||
| srcs = ["utils.cc"], | ||
| hdrs = ["utils.h"], | ||
| deps = [ | ||
| ":parser_lib", | ||
| "//source/common/common:statusor_lib", | ||
| ], | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.