Skip to content

Add dev docs for examples verify.sh#12874

Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
phlax:verify-examples-reprise--docs
Sep 9, 2020
Merged

Add dev docs for examples verify.sh#12874
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
phlax:verify-examples-reprise--docs

Conversation

@phlax
Copy link
Member

@phlax phlax commented Aug 28, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: Add dev docs for examples verify.sh
Additional Description:
Adds docs for adding example sandboxes

Documentation for #12491 - separated here so as not to complexify that pr any further.

Risk Level: low
Testing:
Docs Changes: yep
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] related to #12491
[Optional Deprecated:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Aug 28, 2020

add sections (done):

  • additional args to docker-compose up -d
  • running commands inside docker containers

phlax added 2 commits August 29, 2020 09:54
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some questions:

Signed-off-by: Ryan Northey <ryan@synca.io>
dio
dio previously approved these changes Aug 31, 2020
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Ryan Northey <ryan@synca.io>
dio
dio previously approved these changes Aug 31, 2020
@phlax
Copy link
Member Author

phlax commented Aug 31, 2020

@lizan not sure if you want to check over this before its merged

...as it documents #12491 which hasnt yet landed

Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dio
Copy link
Member

dio commented Sep 2, 2020

/assign @lizan

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@mattklein123 mattklein123 merged commit c02d336 into envoyproxy:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants