udpa: context parameter encoding.#12806
Merged
htuch merged 7 commits intoenvoyproxy:masterfrom Sep 10, 2020
Merged
Conversation
This patch introduces the xDS transport++ context parameter encoding algorithm. Risk level: Low Testing: Unit tests added. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@roth @mattklein123 friendly ping when you get a chance. |
markdroth
reviewed
Sep 8, 2020
Contributor
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
This looks good overall. Just one minor suggestion for the test.
markdroth
previously approved these changes
Sep 8, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Sep 9, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comments, thank you!
/wait
Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the xDS transport++ context parameter encoding
algorithm.
Risk level: Low
Testing: Unit tests added.
Signed-off-by: Harvey Tuch htuch@google.com