test: refactor header inclusion to speed up building (for test/common/http)#12775
Merged
asraa merged 3 commits intoenvoyproxy:masterfrom Aug 26, 2020
Merged
test: refactor header inclusion to speed up building (for test/common/http)#12775asraa merged 3 commits intoenvoyproxy:masterfrom
asraa merged 3 commits intoenvoyproxy:masterfrom
Conversation
Member
|
Out of curiosity, do you have benchmark numbers of how much this speeds up the build? |
Contributor
Author
@derekargueta
For some test the building time does not change much, since |
Member
|
Super cool, thanks for sharing! |
Member
|
@foreseeable was this done with a tool or manually? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muge Chen mugechen@google.com
Commit Message: refactor header inclusion to speed up building
Additional Description: This is the follow up PR for dividing the monolithic mock header test/mocks/upstream/mocks.h #12048
We refactored mock class include directives, this will reduce the target size and building time.
Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: no