test: refactor header inclusion to speed up building (for test/common/upstream)#12774
Merged
asraa merged 13 commits intoenvoyproxy:masterfrom Aug 28, 2020
Merged
test: refactor header inclusion to speed up building (for test/common/upstream)#12774asraa merged 13 commits intoenvoyproxy:masterfrom
asraa merged 13 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Muge Chen <mugechen@google.com>
Contributor
Author
|
\cc @asraa |
foreseeable
force-pushed
the
refactor_c_upstream
branch
from
94cb2c0 to
32e5f8e
Compare
Signed-off-by: Muge Chen <mugechen@google.com>
Contributor
|
@snowp @foreseeable 's last day is tomorrow - would appreciate any comments on this PR so we can address them before he returns to school. Thanks! |
asraa
reviewed
Aug 27, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks, LGTM besides the two comments
/wait
Signed-off-by: Muge Chen <mugechen@google.com>
clarakosi
pushed a commit
to clarakosi/envoy
that referenced
this pull request
Sep 3, 2020
…/upstream) (envoyproxy#12774) Commit Message: refactor header inclusion to speed up building Additional Description: This is the follow up PR for dividing the monolithic mock header test/mocks/upstream/mocks.h envoyproxy#12048 We refactored mock class include directives, this will reduce the target size and building time. Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: refactor header inclusion to speed up building
Additional Description: This is the follow up PR for dividing the monolithic mock header test/mocks/upstream/mocks.h #12048
We refactored mock class include directives, this will reduce the target size and building time.
Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: no