listener: fix inplace update with conn balancer#12748
listener: fix inplace update with conn balancer#12748mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks for the quick fix. A small test comment. Thank you!
/wait
| bootstrap.mutable_static_resources() | ||
| ->mutable_listeners(0) | ||
| ->mutable_connection_balance_config() | ||
| ->mutable_exact_balance(); |
There was a problem hiding this comment.
Can you make this a setup param and test this both ways (default off is fine just want to have at least 1 test where we have the other config.)
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
was this fixed by another PR? or can we reopen this? |
|
@lambdai can you finish this fix? Otherwise I can do it this week. |
stale
bot
removed
the
stale
|
Sorry… updating this pr. |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with small comments.
/wait
| see a change in behavior. | ||
| * logging: add fine-grain logging for file level log control with logger management at administration interface. It can be enabled by option `--enable-fine-grain-logging`. | ||
| * logging: change default log format to `"[%Y-%m-%d %T.%e][%t][%l][%n] [%g:%#] %v"` and default value of :option:`--log-format-prefix-with-location` to `0`. | ||
| * listener: fixed crash at listener inplace update when connetion load balancer is set. |
There was a problem hiding this comment.
Can you move this to the bug fix section?
| Network::Address::InstanceConstSharedPtr address_; | ||
| }; | ||
| bool use_default_balancer_{false}; | ||
| }; // namespace |
| name_(name), listener_filters_timeout_(listener_filters_timeout), | ||
| continue_on_listener_filters_timeout_(continue_on_listener_filters_timeout), | ||
| connection_balancer_(std::make_unique<Network::NopConnectionBalancerImpl>()), | ||
|
|
| listener_filters_timeout_( | ||
| PROTOBUF_GET_MS_OR_DEFAULT(config, listener_filters_timeout, 15000)), | ||
| continue_on_listener_filters_timeout_(config.continue_on_listener_filters_timeout()), | ||
| connection_balancer_(origin.connection_balancer_), |
3 participants
Commit Message:
By sharing the connection balancer among listener configs.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
Fixes #12686
[Optional Deprecated:]