Closed
Conversation
Member
|
@junr03 Can this be closed? |
Member
Author
|
Yeah I will close it. Long story short, Travis still hasn't finished straightening all of this, but I have someone working on it. I will test again when they tell me it is done. |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Add the allow_missing_or_failed option to jwt-auth **What this PR does / why we need it**: Add the allow_missing_or_failed option to jwt-auth so jwt-auth won't return 401 when jwt is missing or the jwt authentication fails. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1212 **Special notes for your reviewer**: **Release note**: ```release-note ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: A member pointer was erroneously being accessed that should have been a local. Fixed and refactored to simplify call path. Risk Level: Low Testing: New coverage will be added in upcoming PR Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: A member pointer was erroneously being accessed that should have been a local. Fixed and refactored to simplify call path. Risk Level: Low Testing: New coverage will be added in upcoming PR Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to travis people, language minimal is now fully supported. Testing that.