Revert buffer filter visibility back to public#12579
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Aug 11, 2020
Merged
Revert buffer filter visibility back to public#12579lizan merged 2 commits intoenvoyproxy:masterfrom
lizan merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lisa Lu <lisalu@lyft.com>
mattklein123
previously approved these changes
Aug 10, 2020
lizan
reviewed
Aug 10, 2020
Member
Signed-off-by: Lisa Lu <lisalu@lyft.com>
lizan
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lisa Lu lisalu@lyft.com
Commit Message: Revert buffer filter visibility back to public
Additional Description: After bringing in #12337, we are unable to build the router check tool as we build it with the buffer filter extension, which is no longer visible to the target we use. This change reverts the visibility change for the buffer filter back to public.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Part of #12444