Add const qualifier to returned pointers in MockIp and MockResolvedAddress#12573
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 10, 2020
Merged
Conversation
…dress Compared to their superclasses, the MockIp and MockResolvedAddress classes dropp the const qualifier from the pointers they return. Since the non-mock class implementing these methods return const pointers, it’s difficult to use non-mock classes with these mocks without resorting to hacks like const_cast. Risk Level: low Testing: bazel test //test/extensions/filters/network/rocketmq_proxy/... //test/common/network:resolver_test //test/common/router:config_impl_test Documentation: N/A Release Notes: N/A Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
justin-mp
force-pushed
the
fix-mock-const-pointers
branch
from
39d1120 to
d624949
Compare
jmarantz
approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to their superclasses, the MockIp and MockResolvedAddress
classes drop the const qualifier from the pointers they return.
Since the non-mock class implementing these methods return const
pointers, it’s difficult to use non-mock classes with these mocks
without resorting to hacks like const_cast.
Risk Level: low
Testing: bazel test //test/extensions/filters/network/rocketmq_proxy/... //test/common/network:resolver_test //test/common/router:config_impl_test
Documentation: N/A
Release Notes: N/A
Signed-off-by: Justin Mazzola Paluska justinmp@google.com