build: Fix that custom docker image build#12564
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Aug 11, 2020
Merged
Conversation
The do_ci.sh builds the envoy and copies binary to under build-* directories. But recently, the arm64 build system was added but it does not consider the previous custom docker image build. It is very useful to build the custom docker image and test it within k8s environment. So, this patch support previous behavior again so that we can build the custom docker image. If some more cpu architectures are added, we can simple extends more cpu architectures. Signed-off-by: DongRyeol Cha <dr83.cha@samsung.com>
lizan
suggested changes
Aug 11, 2020
ci/build_setup.sh
Outdated
ci/do_ci.sh
Outdated
Comment on lines
23
to
25
Member
There was a problem hiding this comment.
There are folks building on ppc64le / s390x, Shouldn't fail hard here. Just fall back to linux/${ENVOY_BUILD_ARCH}?
Contributor
Author
There was a problem hiding this comment.
NP. I will revise my patch.
Signed-off-by: DongRyeol Cha <dr83.cha@samsung.com>
chadr123
force-pushed
the
fix_custom_build_for_dev
branch
from
7d9a265 to
ac84bdd
Compare
Contributor
Author
|
I have changed my patch. Please check it. :) |
lizan
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
The do_ci.sh builds the envoy and copies binary to under build-* directories.
But recently, the arm64 build system was added but it does not consider the
previous custom docker image build.
It is very useful to build the custom docker image and test it within k8s environment.
So, this patch support previous behavior again so that we can build the custom docker image.
If some more cpu architectures are added, we can simple extends more cpu architectures.
Signed-off-by: DongRyeol Cha dr83.cha@samsung.com
Additional Description: None
Risk Level: Low
Testing: bazel test and bazel build
Docs Changes: None
Release Notes: None