Merged
Conversation
Pulls in TSAN mutex fixes as well as works around false detection. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
Member
Author
|
I will look at the error here. Oddly I'm not seeing this error on my other branch where I fix a bunch of other things. I will see if I can do a quick fix here to unblock this. |
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
jmarantz
previously approved these changes
Aug 10, 2020
Member
Author
|
I already fixed this latest flake on my next branch, but I guess I should do some type of interim fix here since this will likely flake a lot. This is fun. :( |
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
jmarantz
approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in TSAN mutex fixes as well as works around false detection.
Signed-off-by: Matt Klein mklein@lyft.com
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A