Cleanup: cleaning up .first/.second [source/common/config]#12468
Merged
mattklein123 merged 9 commits intoenvoyproxy:masterfrom Aug 10, 2020
Merged
Cleanup: cleaning up .first/.second [source/common/config]#12468mattklein123 merged 9 commits intoenvoyproxy:masterfrom
mattklein123 merged 9 commits intoenvoyproxy:masterfrom
Conversation
added 7 commits
July 29, 2020 16:50
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Contributor
Author
Member
asraa
suggested changes
Aug 7, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks! Just one small nit, otherwise names look good to me. Nice @ re-using the existing aliases.
added 2 commits
August 7, 2020 20:16
Signed-off-by: Yifan Yang <needyyang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR to this #12354. This time is in the common/config submodule.
Commit Message:
Additional Description:
Risk Level: Low, solely cosmetic changes.
Testing: All existing tests passed.
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]